Skip to content

Conversation

@LaszloLango
Copy link
Contributor

Related issue: #257
Related test262 tests:

  • ch15/15.10/15.10.2/S15.10.2_A1_T1
  • ch15/15.10/15.10.2/15.10.2.6/S15.10.2.6_A4_T7

@LaszloLango LaszloLango added bug Undesired behaviour ecma builtins Related to ECMA built-in routines labels Aug 3, 2015
@LaszloLango LaszloLango added this to the ECMA builtins milestone Aug 3, 2015
@LaszloLango LaszloLango assigned egavrin and sand1k and unassigned egavrin Aug 3, 2015
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the match limit counter should be removed from the executor context as well, since we don't use it anymore.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dbatyai, fixed.

@LaszloLango LaszloLango force-pushed the fix_regexp_match_on_right_brackets branch from 443011d to fc50238 Compare August 4, 2015 11:27
@egavrin
Copy link
Contributor

egavrin commented Aug 4, 2015

Good to me

@egavrin egavrin assigned galpeter and unassigned sand1k Aug 4, 2015
JerryScript-DCO-1.0-Signed-off-by: László Langó llango.u-szeged@partner.samsung.com
JerryScript-DCO-1.0-Signed-off-by: László Langó llango.u-szeged@partner.samsung.com
@LaszloLango LaszloLango force-pushed the fix_regexp_match_on_right_brackets branch from fc50238 to a9121d2 Compare August 4, 2015 13:09
@dbatyai
Copy link
Member

dbatyai commented Aug 4, 2015

Looks good to me

@LaszloLango LaszloLango assigned egavrin and unassigned galpeter Aug 4, 2015
@dbatyai
Copy link
Member

dbatyai commented Aug 4, 2015

Landed: 7a3636b & 5733690

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Undesired behaviour ecma builtins Related to ECMA built-in routines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants