Skip to content

CMake update cmake_minimum_required (VERSION 3.10) #5187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

lygstate
Copy link
Contributor

@lygstate lygstate commented Dec 6, 2024

CMake Deprecation Warning at jerry-port/CMakeLists.txt:15 (cmake_minimum_required):
  Compatibility with CMake < 3.10 will be removed from a future version of
  CMake.

JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo luoyonggang@gmail.com

JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo luoyonggang@gmail.com
@LaszloLango
Copy link
Contributor

Why? Do we know that the project does not build with older cmake versions than 3.10?

@lygstate
Copy link
Contributor Author

lygstate commented Dec 11, 2024

Why? Do we know that the project does not build with older cmake versions than 3.10?

Because newest cmake are deprecating cmake before 3.10

https://github.com/jerryscript-project/jerryscript/actions/runs/12069004842/job/33655344964#step:6:101

CMake Deprecation Warning at jerry-port/CMakeLists.txt:15 (cmake_minimum_required):
  Compatibility with CMake < 3.10 will be removed from a future version of
  CMake.

@LaszloLango
Copy link
Contributor

Fair enough, good to me. Thanks.

@LaszloLango LaszloLango added this to the Release 3.0.0 milestone Dec 11, 2024
@zherczeg
Copy link
Member

3.10 release date: 20 November 2017. Not that long ago.

@lygstate
Copy link
Contributor Author

3.10 release date: 20 November 2017. Not that long ago.

cmake have released binary can installed on very old system, so that's may not a issue https://cmake.org/download/

@ossy-szeged
Copy link
Contributor

ossy-szeged commented Dec 11, 2024

just a note: Ubuntu 18.04 - which already reached its EOL on 2023.05.31 - shipped cmake 3.10
I don't think it is a big thing to require at least 3.10 version.

Not to mention that github CI has only cmake 3.31 on each supported Ubuntu runner (20.04, 22.04 and 24.04) and we don't test if the minimum cmake version works or not. Maybe we could add one more CI job to ensure that out minimum
requirement cmake version works - https://github.com/marketplace/actions/get-cmake

Just out of curiosity, is 2.8.12 build still works?

Copy link
Contributor

@robertsipka robertsipka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robertsipka robertsipka merged commit f0a249d into jerryscript-project:master Dec 17, 2024
26 checks passed
@lygstate lygstate deleted the cmake-update branch December 17, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants