-
Notifications
You must be signed in to change notification settings - Fork 683
CMake update cmake_minimum_required (VERSION 3.10) #5187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo luoyonggang@gmail.com
Why? Do we know that the project does not build with older cmake versions than 3.10? |
Because newest cmake are deprecating cmake before 3.10
|
Fair enough, good to me. Thanks. |
3.10 release date: 20 November 2017. Not that long ago. |
cmake have released binary can installed on very old system, so that's may not a issue https://cmake.org/download/ |
just a note: Ubuntu 18.04 - which already reached its EOL on 2023.05.31 - shipped cmake 3.10 Not to mention that github CI has only cmake 3.31 on each supported Ubuntu runner (20.04, 22.04 and 24.04) and we don't test if the minimum cmake version works or not. Maybe we could add one more CI job to ensure that out minimum Just out of curiosity, is 2.8.12 build still works? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo luoyonggang@gmail.com