Skip to content

Conversation

@bzsolt
Copy link
Member

@bzsolt bzsolt commented Nov 20, 2015

No description provided.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would require to manually update contents of jerry-all-in.cpp upon adding / removing / renaming a module.

It would be better, if the file would be created automatically during build and if it would be placed in cmake's build directory instead of repository's root.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@egavrin egavrin added enhancement An improvement infrastructure Related to GH Actions or the tested targets labels Nov 23, 2015
@kkristof kkristof assigned ruben-ayrapetyan and unassigned bzsolt Nov 25, 2015
@ruben-ayrapetyan
Copy link

Looks good to me

@LaszloLango
Copy link
Contributor

LGTM

Zsolt Borbély added 2 commits November 25, 2015 14:01
JerryScript-DCO-1.0-Signed-off-by: Zsolt Borbély zsborbely.u-szeged@partner.samsung.com
Related issue: jerryscript-project#626

JerryScript-DCO-1.0-Signed-off-by: Zsolt Borbély zsborbely.u-szeged@partner.samsung.com
@LaszloLango LaszloLango merged commit fe15730 into jerryscript-project:master Nov 25, 2015
@bzsolt bzsolt deleted the all-in-one_build branch June 17, 2016 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement An improvement infrastructure Related to GH Actions or the tested targets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants