Merge the js-parser and parser files #859
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerry-core/parser/js/js-parser.cpp
Outdated
| ecma_compiled_code_t * | ||
| parser_parse_script (const uint8_t *source_p, /**< valid UTF-8 source code */ | ||
| static ecma_compiled_code_t * | ||
| parse_script (const uint8_t *source_p, /**< valid UTF-8 source code */ |
Member
There was a problem hiding this comment.
Parameters are not aligned.
And I would prefer parser_parse_source
robertsipka
force-pushed
the
refactor_parser
branch
from
b864438 to
b3778d0
Compare
Contributor
Author
|
Thanks the comments. Fixed. |
JerryScript-DCO-1.0-Signed-off-by: Robert Sipka rsipka.uszeged@partner.samsung.com
robertsipka
force-pushed
the
refactor_parser
branch
from
b3778d0 to
f701874
Compare
Contributor
Author
|
Updated. |
Member
|
LGTM |
LaszloLango
changed the title
Contributor
|
Landed (b0bdf0e) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.