Skip to content

Conversation

@akosthekiss
Copy link
Member

They are identical to the functions with the same name in
jerry-port.cpp and cause duplicate symbol link errors on OS X.

JerryScript-DCO-1.0-Signed-off-by: Akos Kiss akiss@inf.u-szeged.hu

@akosthekiss akosthekiss added bug Undesired behaviour minor labels Feb 13, 2016
@akosthekiss
Copy link
Member Author

BTW, the link error messages are:

duplicate symbol _jerry_port_logmsg in:
    CMakeFiles/unit-test-api.dir/tests/unit/test-api.cpp.o
    jerry-core/libunittests.jerry-core.a(jerry-all-in.cpp.o)
duplicate symbol _jerry_port_errormsg in:
    CMakeFiles/unit-test-api.dir/tests/unit/test-api.cpp.o
    jerry-core/libunittests.jerry-core.a(jerry-all-in.cpp.o)
duplicate symbol _jerry_port_putchar in:
    CMakeFiles/unit-test-api.dir/tests/unit/test-api.cpp.o
    jerry-core/libunittests.jerry-core.a(jerry-all-in.cpp.o)
ld: 3 duplicate symbols for architecture x86_64

@seanshpark
Copy link
Contributor

+1

@akosthekiss akosthekiss force-pushed the unittest-jerry-port-dup-removal branch 2 times, most recently from 4925e48 to f761459 Compare February 15, 2016 17:44
@LaszloLango
Copy link
Contributor

LGTM

@akosthekiss
Copy link
Member Author

Merged in 7dc0658

@akosthekiss akosthekiss deleted the unittest-jerry-port-dup-removal branch February 16, 2016 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Undesired behaviour minor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants