Non-recursive vm_loop #920
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaszloLango
added
enhancement
Member
Author
|
On RPi2, controlflow-recursive.js memory is reduced by 37.5%, and 3d-cube.js memory is reduced by 18.1%. Other tests are unaffected. Please check the patch. |
| static void | ||
| opfunc_call (vm_frame_ctx_t *frame_ctx_p) /**< frame context */ | ||
| { | ||
| uint8_t opcode = frame_ctx_p->byte_code_p[0]; |
Contributor
There was a problem hiding this comment.
I think we should use uint32_t or uint16_t instead.
zherczeg
force-pushed
the
non_recursive_vm_loop
branch
from
2d82f4f to
74f9f49
Compare
Member
Author
|
Patch updated. |
Contributor
|
LGTM |
JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg zherczeg.u-szeged@partner.samsung.com
zherczeg
force-pushed
the
non_recursive_vm_loop
branch
from
74f9f49 to
e59cd95
Compare
Member
Author
|
self LGTM |
Member
Author
|
Landed in 1200be4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Processing calls is removed from vm_loop which heavily improves the performance of recursive heavy benchmarks. E.g. controlflow-recursive memory consumption is reduced by 37%.