Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build on web #77

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Fix build on web #77

merged 1 commit into from
Sep 10, 2024

Conversation

janek515
Copy link
Contributor

@janek515 janek515 commented Aug 22, 2024

This fixes the invalid type used in rsa_web.dart causing it to not build.

@janek515
Copy link
Contributor Author

janek515 commented Sep 3, 2024

@jerson

@jerson jerson merged commit 13fc5ed into jerson:master Sep 10, 2024
3 of 5 checks passed
@nilsreichardt
Copy link
Contributor

@jerson Can you publish a new version on pub.dev with this fix?

@jerson
Copy link
Owner

jerson commented Oct 10, 2024

Yeah sorry I forgot to publish to pub.dev, will do it a few minutes

@jerson
Copy link
Owner

jerson commented Oct 10, 2024

done, there is still this warning

* `dart analyze` found the following issue(s):
  Analyzing lib, pubspec.yaml...
  
    error - lib/web/rsa_web.dart:10:26 - The argument type 'String' can't be assigned to the parameter type 'JSAny'.  - argument_type_not_assignable
  
  1 issue found.


I may need to prepare a new version soon, but in the mid time hope this helps

jerson added a commit that referenced this pull request Oct 12, 2024
@jerson jerson mentioned this pull request Oct 12, 2024
jerson added a commit that referenced this pull request Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants