Merge pull request #804 from nsano-rururu/fix_spike_rule

Fix SpikeRule
jertel · Apr 6, 2022 · 4fe37e5 · 4fe37e5
2 parents 73a9364 + 6607559
commit 4fe37e5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -30,6 +30,7 @@
 - Update schema.yaml(Alertmanager, Spike, Flatline, New Term, Metric Aggregation, Percentage Match) - [#789](https://github.com/jertel/elastalert2/pull/789) - @nsano-rururu
 - Upgrade pylint 2.13.2 to 2.13.3 - [#792](https://github.com/jertel/elastalert2/pull/792) - @nsano-rururu
 - Upgrade pylint 2.13.3 to 2.13.4 - [#801](https://github.com/jertel/elastalert2/pull/801) - @nsano-rururu
+- Fix SpikeRule - [#804](https://github.com/jertel/elastalert2/pull/804) - @nsano-rururu
 
 # 2.4.0
 

diff --git a/elastalert/ruletypes.py b/elastalert/ruletypes.py
@@ -448,7 +448,7 @@ def get_spike_values(self, qk):
  extending ref/cur value retrieval logic for spike aggregations
  """
  spike_check_type = self.rules.get('metric_agg_type')
- if spike_check_type in [None, 'sum', 'value_count']:
+ if spike_check_type in [None, 'sum', 'value_count', 'cardinality', 'percentile']:
  # default count logic is appropriate in all these cases
  return self.ref_windows[qk].count(), self.cur_windows[qk].count()
  elif spike_check_type == 'avg':