Skip to content

Commit

Permalink
Correct line spacing issues; Sync changelog with closed PRs
Browse files Browse the repository at this point in the history
  • Loading branch information
jertel committed Jul 25, 2021
1 parent 8b8c04b commit 57cdb1a
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 3 deletions.
8 changes: 7 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,18 +15,24 @@
## Breaking changes
- [VictorOps] Changed `state_message` and `entity_display_name` values to be taken from an alert rule. - [#329](https://github.com/jertel/elastalert2/pull/329) - @ChristophShyper
- Potentially a breaking change if the alert subject changes due to the new default behavior.
- Change metric/percentage rule types to store query_key as dict, instead of string, for consistency with other rule types. [#340](https://github.com/jertel/elastalert2/issues/340) - @AntoineBlaud

## New features
- None

## Other changes
- [Tests] Improve test code coverage - [#331](https://github.com/jertel/elastalert2/pull/331) - @nsano-rururu
- [Docs] Upgrade Sphinx from 4.0.2 to 4.1.1 - [#344](https://github.com/jertel/elastalert2/pull/344) - @nsano-rururu
- [Tests] Upgrade Tox from 3.23.1 to 3.24.0 - [#345](https://github.com/jertel/elastalert2/pull/345) - @nsano-rururu
- Upgrade Jinja from 2.11.3 to 3.0.1 - [#350](https://github.com/jertel/elastalert2/pull/350) - @mrfroggg
- [Tests] Add test code. Changed ubuntu version of Dockerfile-test from latest to 21.10. - [#354](https://github.com/jertel/elastalert2/pull/354) - @nsano-rururu
- [Tests] Improved test coverage for opsgenie.py 96% to 100% - [#364](https://github.com/jertel/elastalert2/pull/364) - @nsano-rururu
- Remove Python 2.x compatibility code - [#354](https://github.com/jertel/elastalert2/pull/354) - @nsano-rururu
- [Docs] Added Chatwork proxy settings to documentation - [#360](https://github.com/jertel/elastalert2/pull/360) - @nsano-rururu
- Add settings to schema.yaml(Chatwork proxy, Dingtalk proxy) - [#361](https://github.com/jertel/elastalert2/pull/361) - @nsano-rururu
- [Docs] Tidy Twilio alerter documentation - [#363](https://github.com/jertel/elastalert2/pull/363) - @ferozsalam
- [Tests] Improve opsgenie test code coverage - [#364](https://github.com/jertel/elastalert2/pull/364) - @nsano-rururu
- [Docs] Update mentions of JIRA to Jira - [#365](https://github.com/jertel/elastalert2/pull/365) - @ferozsalam
- Add settings to schema.yaml(Chatwork proxy, Dingtalk proxy) - [#361](https://github.com/jertel/elastalert2/pull/361) - @nsano-rururu

# 2.1.2
## Breaking changes
Expand Down
1 change: 0 additions & 1 deletion tests/rules_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -1168,7 +1168,6 @@ def test_metric_aggregation():
rule.check_matches(datetime.datetime.now(), 'qk_val', {'metric_cpu_pct_avg': {'value': 0.95}})
assert rule.matches[0]['subdict'] == 'qk_val'


rules['query_key'] = 'subdict1.subdict2.subdict3'
rule = MetricAggregationRule(rules)
rule.check_matches(datetime.datetime.now(), 'qk_val', {'metric_cpu_pct_avg': {'value': 0.95}})
Expand Down
3 changes: 2 additions & 1 deletion tests/util_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -466,9 +466,10 @@ def test_expand_string_into_dict():
string = 'metadata.source.ip'
value = '0.0.0.0'

dictionnary_result = expand_string_into_dict(dictionnary, string, value)
expand_string_into_dict(dictionnary, string, value)
assert dictionnary['metadata']['source']['ip'] == value


def test_inc_ts():
dt = datetime(2021, 7, 6, hour=0, minute=0, second=0)
actual = inc_ts(dt)
Expand Down

0 comments on commit 57cdb1a

Please sign in to comment.