-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add_alertmanager_resolve_timeout #1187
Conversation
The thing is, alertmanager has a default resov_timeout is 5 minutes, meaning after 5 minutes if it doesn't r receive any repeat alert it will consider the alert stop firing. Sure, you can set "realert" below 5 min in your rules to keep alert fire, but it will affect another alert output. I think the best option is we can keep that timeout configurable in the rules, like this :\
Users who config the rules can be aware of this config and expect the right behavior for alertmanager. |
Please add alertmanager_resolve_timeout to the documentation. If there is a default value, please also provide the default value. Please use the validation check setting of alertmanager_resolve_timeout alertmanager_resolve_timeout: {type: integer} |
Please add test code for alertmanager_resolve_timeout |
Please update CHANGELOG.md |
ok I'll do it now. ~ chotto matte. But the ideal ok right? |
Hello @eveningcafe: Are you planning to continue this PR? If so I'll leave it open for a couple more weeks. Let us know. Thanks! |
oh yes, sorry. I'll do. please leave it open |
Are there minimum and maximum values for alertmanager_resolve_timeout settings? |
Hey guys, how does mock build respose of my request to 'http://alertmanager:9093' ? Here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I refactored your implementation to make it a non-breaking change, and to utilize a consistent time configuration, similar to timeframe and buffer_time. Also added a unit test.
Description
Checklist
make test-docker
with my changes.Questions or Comments