Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pylint, pytest, pytest-cov, pytest-xdist, sphinx #1194

Merged

Conversation

nsano-rururu
Copy link
Collaborator

@nsano-rururu nsano-rururu commented Jun 7, 2023

pylint 2.17.0 to 2.17.4
pytest 7.2.2 to 7.3.1
pytest-cov 4.0.0 to 4.1.0
pytest-xdist 3.2.0 to 3.3.1
sphinx 6.13 to 6.2.1
sphinx_rtd_theme == 1.2.2

Description

Checklist

  • I have reviewed the contributing guidelines.
  • I have included unit tests for my changes or additions.
  • I have successfully run make test-docker with my changes.
  • I have manually tested all relevant modes of the change in this PR.
  • I have updated the documentation.
  • I have updated the changelog.

Questions or Comments

pylint 2.17.0 to 2.17.4
pytest 7.2.2 to 7.3.1
pytest-cov 4.0.0 to 4.1.0
pytest-xdist 3.2.0 to 3.3.1
sphinx 6.13 to 6.2.1
sphinx_rtd_theme == 1.2.2
jertel
jertel previously approved these changes Jun 7, 2023
@nsano-rururu
Copy link
Collaborator Author

memo

  • Waiting for sphinx7 support for sphinx_rtd_theme
  • I don't have time to investigate how to deal with tox 3 and 4

@jertel jertel merged commit d84aca4 into jertel:master Jun 7, 2023
@jertel
Copy link
Owner

jertel commented Jun 7, 2023

memo

  • Waiting for sphinx7 support for sphinx_rtd_theme
  • I don't have time to investigate how to deal with tox 3 and 4

Have you tried Tox 4.6.0? I just ran a make test-docker using that version and everything passes. The output looks a little different but it's mostly very similar to 3.x. If you know of a reason to avoid upgrading I will hold off, otherwise I can submit a PR for it.

@nsano-rururu nsano-rururu deleted the update_pylint_pytest_cov_xdist_shinx branch June 7, 2023 17:58
@nsano-rururu
Copy link
Collaborator Author

memo

  • Waiting for sphinx7 support for sphinx_rtd_theme
  • I don't have time to investigate how to deal with tox 3 and 4

Have you tried Tox 4.6.0? I just ran a make test-docker using that version and everything passes. The output looks a little different but it's mostly very similar to 3.x. If you know of a reason to avoid upgrading I will hold off, otherwise I can submit a PR for it.

If it works with tox 4.6.0, there is no reason not to update. Please make a pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants