Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional EQL support #1195

Merged
merged 5 commits into from
Jun 8, 2023
Merged

Additional EQL support #1195

merged 5 commits into from
Jun 8, 2023

Conversation

jertel
Copy link
Owner

@jertel jertel commented Jun 7, 2023 •
edited
Loading

Description

Cleaned up new unit tests.
Improve the elastalert-test-rule tool with EQL filters to prevent a benign "count" query error message.

Checklist

  • I have reviewed the contributing guidelines.
  • I have included unit tests for my changes or additions.
  • I have successfully run make test-docker with my changes.
  • I have manually tested all relevant modes of the change in this PR.
  • I have updated the documentation.
  • I have updated the changelog.

Questions or Comments

N/A

@jertel jertel requested a review from nsano-rururu June 7, 2023 20:25
@jertel jertel merged commit a0089c2 into master Jun 8, 2023
@jertel jertel deleted the eql branch June 14, 2023 21:27
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nsano-rururu nsano-rururu Awaiting requested review from nsano-rururu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jertel