Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify use of flatline query_key values in alerts #1320

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Conversation

jertel
Copy link
Owner

@jertel jertel commented Nov 28, 2023

Description

Minor doc update for Flatline alerts.

Checklist

  • I have reviewed the contributing guidelines.
  • (N/A) I have included unit tests for my changes or additions.
  • I have successfully run make test-docker with my changes.
  • (N/A) I have manually tested all relevant modes of the change in this PR.
  • I have updated the documentation.
  • I have updated the changelog.

Questions or Comments

@nsano-rururu
Copy link
Collaborator

My understanding is that the following behavior has been added to the documentation. Thank you for your response.
fix a bug where realert doesnt respect query_key when using flatline
Yelp/elastalert#1179

@nsano-rururu nsano-rururu merged commit 7e60c67 into master Nov 28, 2023
1 check passed
@jertel
Copy link
Owner Author

jertel commented Nov 28, 2023

My understanding is that the following behavior has been added to the documentation. Thank you for your response. fix a bug where realert doesnt respect query_key when using flatline Yelp/elastalert#1179

Yes, that's correct. Thanks for reviewing/merging.

@jertel jertel deleted the jertel/flkey branch November 28, 2023 15:16
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants