Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IRIS and GELF alerter and tests #1331

Merged
merged 5 commits into from
Dec 3, 2023

Conversation

malinkinsa
Copy link
Contributor

@malinkinsa malinkinsa commented Dec 3, 2023

Description

#1317 iris_ca_cert discussion

Checklist

  • I have reviewed the contributing guidelines.
  • I have included unit tests for my changes or additions.
  • I have successfully run make test-docker with my changes.
  • I have manually tested all relevant modes of the change in this PR.
  • I have updated the documentation.
  • I have updated the changelog.

@nsano-rururu
Copy link
Collaborator

Please update the documentation. The default value for gelf_http_ignore_ssl_errors has been omitted, so please correct it accordingly.

https://github.com/jertel/elastalert2/blob/master/docs/source/ruletypes.rst#iris

iris_ca_cert: Path to custom CA certificate.

iris_ca_cert: Set this option to True or a path to a CA cert bundle or directory (eg: /etc/ssl/certs/ca-certificates.crt) to validate the SSL certificate.The default value is: False.

https://github.com/jertel/elastalert2/blob/master/docs/source/ruletypes.rst#graylog-gelf

gelf_http_ignore_ssl_errors: Ignore ssl error. (Only used if gelf_type=http)

gelf_http_ignore_ssl_errors: Ignore ssl error. (Only used if gelf_type=http).The default value is: False.

gelf_ca_cert: Path to custom CA certificate.

gelf_ca_cert: Set this option to True or a path to a CA cert bundle or directory (eg: /etc/ssl/certs/ca-certificates.crt) to validate the SSL certificate.The default value is: False.

@nsano-rururu
Copy link
Collaborator

@jertel
I have nothing more to point out. If there is no problem, please merge.

@jertel jertel merged commit 38ac8e0 into jertel:master Dec 3, 2023
1 check passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants