Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue in IRIS docs and alerter required options #1334

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

malinkinsa
Copy link
Contributor

Description

I found some inaccuracies in the description, which have been corrected. I misunderstood the parameter slightly when adding support. After these changes, it doesn't need to be mandatory anymore, and it can be assigned the default value.

I also displayed scenarios in the tests where it's not set and when it's set to a non-default value.

Checklist

  • I have reviewed the contributing guidelines.
  • I have included unit tests for my changes or additions.
  • I have successfully run make test-docker with my changes.
  • I have manually tested all relevant modes of the change in this PR.
  • I have updated the documentation.
  • I have updated the changelog.

Copy link
Owner

@jertel jertel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the correction.

@jertel jertel merged commit f52a926 into jertel:master Dec 5, 2023
1 check passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants