Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add workwechat alerter #1367

Merged
merged 5 commits into from
Feb 1, 2024
Merged

add workwechat alerter #1367

merged 5 commits into from
Feb 1, 2024

Conversation

wufeiqun
Copy link
Contributor

@wufeiqun wufeiqun commented Jan 30, 2024 •
edited
Loading

Description

Add WorkWechat Alerter

Checklist

  • I have reviewed the contributing guidelines.
  • I have included unit tests for my changes or additions.
  • I have successfully run make test-docker with my changes.
  • I have manually tested all relevant modes of the change in this PR.
  • I have updated the documentation.
  • I have updated the changelog.

Questions or Comments

@nsano-rururu
Copy link
Collaborator

Please add this line to the New features section at the top of CHANGELOG.md:

- Add workwechat alerter - [#1367](https://github.com/jertel/elastalert2/pull/1367) - @wufeiqun

@wufeiqun
Copy link
Contributor Author

Please add this line to the New features section at the top of CHANGELOG.md:

- Add workwechat alerter - [#1367](https://github.com/jertel/elastalert2/pull/1367) - @wufeiqun

already done!

@nsano-rururu
Copy link
Collaborator

@jertel

Do you have any other points?
Please merge unless you have any specific comments.

jertel
jertel approved these changes Feb 1, 2024
View reviewed changes
Copy link
Owner

@jertel jertel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wufeiqun for this useful contribution! Thanks @nsano-rururu for the review!

@jertel jertel merged commit 1fc170a into jertel:master Feb 1, 2024
1 check passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jertel jertel jertel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wufeiqun @nsano-rururu @jertel