Bump python_requires
#1528
Merged
Bump python_requires
#1528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to https://elastalert2.readthedocs.io/en/latest/running_elastalert.html#as-a-python-package this package currently only supports Python 3.12, but that's not actually encoded in the project metadata. As a result, people with older versions of Python can run $ pip install --upgrade elastalert2 and then hit runtime errors like jertel#1400.
kmurphy4
force-pushed
the
fix-python-requires
branch
from
e9c3ec9
to
6769544
Compare
|
Thanks for submitting this. |
jertel
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
According to https://elastalert2.readthedocs.io/en/latest/running_elastalert.html#as-a-python-package this package currently only supports Python 3.12, but that's not actually encoded in the project metadata.
As a result, people with older versions of Python can run
and then hit runtime errors like #1400.
Checklist
make test-dockerwith my changes.Questions or Comments
Since older versions have already been published to PyPI with incorrect
python_requires, this won't actually fix the bug (e.g.,python3.9 -m pip install --upgrade elastalert2will select the incompatible 2.19.0 release). I think if we wanted to fix that, we'd need to yank all the old releases, but that's probably not worthwhile..