Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converting IRIS Alert Source from Hardcoded to Dynamic Alert Field Variable #1531

Merged
merged 7 commits into from
Sep 9, 2024

Conversation

bvirgilioamnh
Copy link
Contributor

Description

Updated the IRIS Alert Source field to read from the alert fields instead of being hardcoded. The alert source field has a default value of the original hardcoded value 'ElastAlert2'. This is to provided additional flexibility when using ElastAlert across multiple solutions.

Checklist

  • I have reviewed the contributing guidelines.
  • I have included unit tests for my changes or additions.
  • I have successfully run make test-docker with my changes.
  • I have manually tested all relevant modes of the change in this PR.
  • I have updated the documentation.
  • I have updated the changelog.

Questions or Comments

@jertel
Copy link
Owner

jertel commented Sep 7, 2024

This looks useful, thank you for submitting it. Will you please update the schema.yml file to include the new IRIS param?

@bvirgilioamnh
Copy link
Contributor Author

This looks useful, thank you for submitting it. Will you please update the schema.yml file to include the new IRIS param?

@jertel you bet, done! Should probably update the contributing.md, I missed that this even existed.

@jertel jertel merged commit a381a73 into jertel:master Sep 9, 2024
1 check passed
@bvirgilioamnh
Copy link
Contributor Author

Thank you :)

@bvirgilioamnh bvirgilioamnh deleted the iris-alert-source branch September 9, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants