Bugfix/1457 fixing iris ioc NoneType #1533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copying the record data into a new private variable resolves the issue.
|
This looks good. Is there any work remaining? |
I think it should be good to go - forgot I opened it as a draft. |
jertel
previously approved these changes
Sep 18, 2024
jertel
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simple PR to fix an issue with how the IRIS alerter handles IOCs in subsequent alerts. The error when the alerter inadvertently overwrites the IOCs dictionary when fetching key/value matches from Elastic. The solution is to simply copy the record data before updating it to ensure it is not overwritten.
I have also added a new test to explicitly test for this error in the future by calling make_alert() twice and validating the output of the second call.
Checklist
make test-dockerwith my changes.Questions or Comments