Speed up unit tests by adding default parallelism #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 18, 2021 08:18
- Also update pytest to a newer version, making other changes required to enable this - On a six-core machine, the test suite now runs in 8s as opposed to ~40s - On a single-core machine, the test suite now runs in ~60s as opposed to ~85s - Have also removed one incorrect use of `raises()` which has been deprecated
ferozsalam
commented
May 18, 2021
| @@ -347,7 +347,7 @@ def test_raises_on_missing_config(): | |||
| mock_rule_open.return_value = test_rule_copy | |||
| with mock.patch('os.walk') as mock_walk: | |||
| mock_walk.return_value = [('', [], ['testrule.yaml'])] | |||
| with pytest.raises(EAException, message='key %s should be required' % key): | |||
There was a problem hiding this comment.
See here for more information on why the message has been removed.
jertel
approved these changes
May 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to enable this
raises()which has been deprecated