Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy example files into a single folder #271

Merged
merged 2 commits into from
Jun 14, 2021

Conversation

ferozsalam
Copy link
Collaborator

This reduces clutter in the root directory and gives us a place to
put all sample files in the future.

Also updates the documentation to point to the new file locations.

This reduces clutter in the root directory and gives us a place to
put all sample files in the future.

Also updates the documentation to point to the new file locations.
Copy link
Owner

@jertel jertel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Found one small typo.

@@ -936,7 +936,7 @@ of the ``compare_key`` field.
Frequency
~~~~~~~~~

For an example configuration file using this rule type, look at ``example_rules/example_frequency.yaml``.
For an example configuration file using this rule type, look at ``example/rules/example_frequency.yaml``.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: example/ should be examples/

Also tweak gitignore to only look for `/rules` folders under the
root directory
@ferozsalam
Copy link
Collaborator Author

Thanks @jertel - now fixed.

@jertel jertel merged commit 82b19ab into jertel:master Jun 14, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants