Fixing the schema for slack_channel_override #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffAshton
force-pushed
the
slack_channel_override
branch
from
19eaace
to
56496e3
Compare
JeffAshton
commented
Jun 25, 2021
| @@ -495,7 +495,7 @@ properties: | |||
| ### Slack | |||
| slack_webhook_url: *arrayOfString | |||
| slack_username_override: {type: string} | |||
| slack_channel_override: {type: string} | |||
| slack_channel_override: *arrayOfString | |||
There was a problem hiding this comment.
slack_channel_override can be either a single string or many:
elastalert2/elastalert/alerters/slack.py
Line 23 in c982b94
jertel
approved these changes
Jun 25, 2021
|
Thank you! |
No, thank you sir for picking up this project. I was on the fence about doing the same. |
|
Is it possible to push a new image version with this fix? |
|
Yes, there's also a helm change that's waiting on a release. Planning to do one this weekend. |
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes schema for slack_channel_override