Force obseravable artifacts to be strings in TheHive #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferozsalam
previously approved these changes
Jun 30, 2021
jertel
requested changes
Jun 30, 2021
There was a problem hiding this comment.
Thanks for the contribution. A unit test to validate that the change is working, and doesn't get reverted by a future commit, would be a good addition. Review this PR if you'd like to see how the other fix tested this: https://github.com/jertel/elastalert2/pull/206/files
Hi @jertel. I've tried to follow what were done with that PR. |
jertel
approved these changes
Jun 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It follows #254 discussion about TheHive alerter.
Without casting, if matched field is an integer as ES schema, TheHive APIs throw an error as they expect strings as data values.