Add impact and urgency as optional params for the servicenow alerter

[randolph-esnet]

Extend the Servicenow alerter to support two new parameters: impact and urgency.

More info on these parameters can be found on the Servicenow doc page on defining priority lookup rules.

These are added as optional parameters to ensure backwards compatibility.

[nsano-rururu]

It's an additional impact and urgency, but I think it's better to prefix it with servicenow_.

[nsano-rururu]

Although it is an additional impact and urgency, since integer is specified in schema.yaml, in the actual rule, if you enclose it in single quotation marks or double quotation marks, an error will occur when executing the actual rule.
It doesn't cause an error in unit tests, but in the sense that it is close to the actual data, I think it is better not to enclose it in single quotes.

[randolph-esnet]

It's an additional impact and urgency, but I think it's better to prefix it with servicenow_.

Thank you. I'll add the servicenow prefix for the new parameters.

[randolph-esnet]

It's an additional impact and urgency, but I think it's better to prefix it with servicenow_.

Thank you. I'll add the servicenow prefix.

[randolph-esnet]

...I think it is beter not to enclose it in single quotes.

To make sure I understand, are you suggesting to omit the quotes in the unit test?

[nsano-rururu]

If schema.yaml is written as follows, the value will be checked and an error will occur when a rule other than 1,2,3 is specified and the rule is executed.

  servicenow_impact: {type: integer, minimum: 1, maximum: 3}
  servicenow_urgency: {type: integer, minimum: 1, maximum: 3}

Supplement. jsonschema checks the key and data type etc. listed in schema.yaml.

[nsano-rururu]

...I think it is beter not to enclose it in single quotes.

To make sure I understand, are you suggesting to omit the quotes in the unit test?

If you don't agree, you can leave it as it is.

[randolph-esnet]

If schema.yaml is written as follows, the value will be checked and an error will occur when a rule other than 1,2,3 is specified and the rule is executed.

  servicenow_impact: {type: integer, minimum: 1, maximum: 3}
  servicenow_urgency: {type: integer, minimum: 1, maximum: 3}

Supplement. jsonschema checks the key and data type etc. listed in schema.yaml.

Great suggestion. Thank you.

[jertel]

Thanks!!