Support character limit for line notify #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jertel
reviewed
Jul 1, 2021
elastalert/alerters/line.py
Outdated
| body += '\n----------------------------------------\n' | ||
| if len(body) > 999: | ||
| body = body[0:900] + '\n *message was cropped according to line notify embed description limits!* ' | ||
| body += '```' |
There was a problem hiding this comment.
What is the purpose of the 3 backticks at the end of the body, on this PR and the one for Chatwork?
There was a problem hiding this comment.
I erased. It's garbage. Discord also has similar trash. discord will be fixed tomorrow.
jertel
approved these changes
Jul 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Line Notify found that the response body size limit was 1,000 bytes, so I decided not to set the excess value in the response body.