-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VictorOps: Set state_message
and entity_display_name
from rule
#329
Conversation
This change adds all data gathered from ElasticSearch to VictorOps's payload, which then can be used easily with transmogrifier. If `victorops_entity_display_name` is not set then `entity_display_name` is taking value of `alert_subject`. Or randomized by VictorOps.
It has changed its original behavior and will not be merged unless you modify the test code. |
I noticed that. Maybe I'll have a look some other day to correct it. |
… to alert payload. * Needed by jertel#329
Hi @nsano-rururu I've updated the tests for the new payload content. |
Isn't it necessary to modify the document? |
… to alert payload. * Needed by jertel#329
You're right. I've added there also information about the default behaviour. |
… to alert payload. * Needed by jertel#329
I think I need to add some test code if victorops_entity_display_name is not set |
… to alert payload. * Added test for a default `entity_display_name`. * Needed by jertel#329
Added it as well now. Sorry, it's 2 AM and I'm working for 18 hours already so my mind is shutting down... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add your changes to 2.x.x New features in change logs.
https://github.com/jertel/elastalert2/blob/master/CHANGELOG.md
… to alert payload. * Fixed unit tests for VictorOps. * Added test for a default `entity_display_name`. * Updated CHANGELOG.md. * Needed by jertel#329
Done. Added as breaking changes, since the subject could change. |
The review is over. Is there anything else I can point out? |
This was added to the Breaking Changes section of the changelog. But is this really a breaking change? For users that have VictorOps in use today, how will upgrading to the next version break their alerts? |
Depending on transmogrifier configuration, if it reads alert subject might not trigger notification if the subject was changed. I don't remember the details anymore, originally I made this change 2 years ago. Haven't seen VictorOps since almost the same time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick response, and for the PR contribution. Hoping you get some time off soon! :)
This change adds all data gathered from ElasticSearch to VictorOps's payload, which then can be used easily with transmogrifier.
If
victorops_entity_display_name
is not set thenentity_display_name
is taking value ofalert_subject
. Or randomized by VictorOps.