add a path exist check for rules_folder config var #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffAshton
reviewed
Oct 21, 2021
| @@ -552,6 +552,8 @@ def get_names(self, conf, use_rule=None): | |||
| rule_files = [] | |||
| if 'scan_subdirectories' in conf and conf['scan_subdirectories']: | |||
| for ruledir in rule_folders: | |||
| if not os.path.exists(ruledir): | |||
| raise EAException('Specified rule_folder does not exist: %s ' % ruledir) | |||
There was a problem hiding this comment.
Can you add a test case for this branch?
There was a problem hiding this comment.
I have added a simple test for invalid path, tests for valid path already exists
|
Thanks for the submission. Please update the CHANGELOG.md with your change and we'll get this merged in. |
Moved to upcoming release section. Remove line item for adding a unit test since it's implied with the actual PR change. Added link to PR.
|
@jertel sorry I got the wrong release, thanks you for the correction |
jertel
approved these changes
Oct 28, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
make test-dockerwith my changes.