Closing the rule schema.yml file stream #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffAshton
commented
Nov 22, 2021
| @@ -137,10 +145,7 @@ class RulesLoader(object): | |||
| jinja_environment = Environment(loader=FileSystemLoader("")) | |||
|
|
|||
| def __init__(self, conf): | |||
| # schema for rule yaml | |||
| self.rule_schema = jsonschema.Draft7Validator( | |||
| yaml.load(open(os.path.join(os.path.dirname(__file__), 'schema.yaml')), Loader=yaml.FullLoader)) | |||
There was a problem hiding this comment.
Chasing down unclosed streams from the yaml library and came across this one. Likely not an issue, but the with open pattern should be followed everywhere.
JeffAshton
commented
Nov 22, 2021
| self.rule_schema = jsonschema.Draft7Validator( | ||
| yaml.load(open(os.path.join(os.path.dirname(__file__), 'schema.yaml')), Loader=yaml.FullLoader)) | ||
|
|
||
| self.rule_schema = load_rule_schema() |
There was a problem hiding this comment.
Existing test coverage utilizes the rule_schema
jertel
approved these changes
Nov 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closing the file stream of
schema.ymlChecklist
make test-dockerwith my changes.