Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for URL shortening on Kibana 7.16 #633

Merged
merged 3 commits into from
Dec 30, 2021
Merged

Add support for URL shortening on Kibana 7.16 #633

merged 3 commits into from
Dec 30, 2021

Conversation

jertel
Copy link
Owner

@jertel jertel commented Dec 29, 2021 •
edited
Loading

Description

Kibana 7.16 changed the URL shortening API. This PR aims to support both the old and new APIs, and auto-detect which one to use based on the rule's kibana_discover_version config setting.

Checklist

  • I have reviewed the contributing guidelines.
  • I have included unit tests for my changes or additions.
  • I have successfully run make test-docker with my changes.
  • I have manually tested all relevant modes of the change in this PR.
  • I have updated the documentation.
  • I have updated the changelog.

Questions or Comments

@jertel
Copy link
Owner Author

jertel commented Dec 29, 2021 •
edited
Loading

Successfully tested against older and new APIs. Below are the Slack message snippets for the URLs in each version:

Kibana 7.16.2:

kibana_discover_url: http://172.17.0.1:5601/goto/0704f7f0-68dd-11ec-b35f-63d7324d06d1

Kibana 7.15.2:

kibana_discover_url: http://172.17.0.1:5601/goto/6ec74ccce6485f2412bcf051b2e2b719

Both URLs correctly loaded in Kibana to the events that triggered the alert.

JeffAshton
JeffAshton previously approved these changes Dec 29, 2021
View reviewed changes
Copy link
Contributor

@JeffAshton JeffAshton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jertel jertel merged commit 52cc847 into master Dec 30, 2021
@jertel jertel deleted the short_url branch December 30, 2021 02:35
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JeffAshton JeffAshton JeffAshton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jertel @JeffAshton