Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load Jinja template when loading an alert #654

Merged
merged 3 commits into from
Jan 12, 2022
Merged

Load Jinja template when loading an alert #654

merged 3 commits into from
Jan 12, 2022

Conversation

thib12
Copy link

@thib12 thib12 commented Jan 11, 2022

Description

Load Jinja template when loading an alert. This enables using alert specific Jinja templates.
Closes #653

Checklist

  • I have reviewed the contributing guidelines.
  • I have included unit tests for my changes or additions.
  • I have successfully run make test-docker with my changes.
  • I have manually tested all relevant modes of the change in this PR.
  • I have updated the documentation.
  • I have updated the changelog.

Questions or Comments

@thib12 thib12 marked this pull request as ready for review January 11, 2022 14:50
@jertel
Copy link
Owner

jertel commented Jan 12, 2022

Please include unit tests on future PRs, or mark a PR as "WIP" meaning it's work-in-progress and the unit tests are coming. I've added the unit test for you on this PR.

Thank you for raising the issue and for submitting the PR!

@jertel jertel merged commit cb274f0 into jertel:master Jan 12, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jinja template is not updated when using an alert-specific alert_text
2 participants