Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Teams] - Kibana Discover URL and Facts #660

Merged
merged 3 commits into from
Jan 18, 2022

Conversation

thib12
Copy link

@thib12 thib12 commented Jan 18, 2022

Description

Just as the Slack alerter supports Kibana Discover URL and Fields, we add these features to the MS Teams alerter. Note that MS Teams does not have fields but facts in their jargon.

Checklist

  • I have reviewed the contributing guidelines.
  • I have included unit tests for my changes or additions.
  • I have successfully run make test-docker with my changes.
  • I have manually tested all relevant modes of the change in this PR.
  • I have updated the documentation.
  • I have updated the changelog.

Questions or Comments

@thib12 thib12 marked this pull request as ready for review January 18, 2022 15:49
@nsano-rururu nsano-rururu requested review from nsano-rururu and removed request for nsano-rururu January 18, 2022 16:27
@jertel jertel merged commit 8b1af58 into jertel:master Jan 18, 2022
@jertel
Copy link
Owner

jertel commented Jan 18, 2022

Thank you for the contribution!

@thib12 thib12 deleted the ms_teams_kibana_discover_url_and_facts branch January 20, 2022 09:39
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants