Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/make rules folder variable #732

Merged
merged 6 commits into from
Feb 21, 2022
Merged

Feat/make rules folder variable #732

merged 6 commits into from
Feb 21, 2022

Conversation

ChrisFraun
Copy link
Contributor

@ChrisFraun ChrisFraun commented Feb 21, 2022 •
edited
Loading

Description

Checklist

  • I have reviewed the contributing guidelines.
  • I have included unit tests for my changes or additions. -> not necessary since nothing changed
  • I have successfully run make test-docker with my changes. -> not necessary since nothing changed
  • I have manually tested all relevant modes of the change in this PR. -> 'helm template .' generates the exact same yaml files
  • I have updated the documentation. -> its documented here on Github
  • I have updated the changelog.

Questions or Comments

jertel
jertel reviewed Feb 21, 2022
View reviewed changes
chart/elastalert2/README.md Outdated Show resolved Hide resolved
jertel
jertel approved these changes Feb 21, 2022
View reviewed changes
Copy link
Owner

@jertel jertel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

@jertel jertel merged commit d9e3dc2 into jertel:master Feb 21, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jertel jertel jertel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChrisFraun @jertel