-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
helm add email config #780
Conversation
What's the benefit of using this vs the suggested method of an extra volume mount (commented out at the bottom of values.yaml)? While this would work it means storing credentials in the values.yaml, vs the suggested method of creating the credentials as a secret separately from the chart's general config. If we proceed with this PR then the documentation needs to be updated in README.md, and an explanation should be included that notes the difference between using this method vs the other method. Also the contributing guidelines must be reviewed and the changelog needs to be updated. |
It is the practice of the multi-volume mount method. Before smtp-auth Secret was created manually. |
Do you think this pr will continue? |
My personal belief is that secrets should not be stored in chart config files, but rather should be managed separately. However, if you (and others) prefer to mix config data with secrets, that is your choice. We can proceed with the PR but you will need to finish the contribution guideline requirements. Specifically:
|
ok, let me continue with the following |
ok, i have done the above |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that I changed the principal key name to smtp_auth.username, for consistency with other fields. Thanks for your contribution.
Description
helm provides email smtp-secret,easy help people use email notification
Only helm configuration changes are included
Checklist
make test-docker
with my changes.Questions or Comments