Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MS Teams] Use alert_subject as ms_teams_alert_summary unless set otherwise #802

Merged
merged 5 commits into from
Apr 5, 2022

Conversation

iamxeph
Copy link
Contributor

@iamxeph iamxeph commented Apr 4, 2022

Description

ms_teams_alert_summary is actually being used in MS Teams for notification title, so it is better to use alert_subject as its default.

For backward compatibility, this PR changes its default to None, and in the alerter code, if ms_teams_alert_summary is None, it will use alert_subject as its value instead.

Checklist

  • I have reviewed the contributing guidelines.
  • I have included unit tests for my changes or additions.
  • I have successfully run make test-docker with my changes.
  • I have manually tested all relevant modes of the change in this PR.
  • I have updated the documentation.
  • I have updated the changelog.

Questions or Comments

@iamxeph iamxeph marked this pull request as ready for review April 5, 2022 00:49
docs/source/ruletypes.rst Outdated Show resolved Hide resolved
Copy link
Owner

@jertel jertel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution to make ElastAlert 2 better!

@jertel jertel merged commit 73a9364 into jertel:master Apr 5, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants