Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make scan subdirectories an option in helm chart #805

Merged
merged 6 commits into from
Apr 6, 2022
Merged

Make scan subdirectories an option in helm chart #805

merged 6 commits into from
Apr 6, 2022

Conversation

louzadod
Copy link
Contributor

@louzadod louzadod commented Apr 5, 2022

Description

Make scan subdirectories an option in helm chart.

Checklist

  • I have reviewed the contributing guidelines.
  • I have included unit tests for my changes or additions.
  • I have successfully run make test-docker with my changes.
  • [x ] I have manually tested all relevant modes of the change in this PR.
  • I have updated the documentation.
  • I have updated the changelog.

Questions or Comments

jertel
jertel requested changes Apr 5, 2022
View reviewed changes
chart/elastalert2/Chart.yaml Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
chart/elastalert2/values.yaml Outdated Show resolved Hide resolved
chart/elastalert2/README.md Outdated Show resolved Hide resolved
@louzadod
Copy link
Contributor Author

louzadod commented Apr 6, 2022

@jertel, see changes after your feedback. Thanks.

jertel
jertel approved these changes Apr 6, 2022
View reviewed changes
Copy link
Owner

@jertel jertel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I fixed the changelog pattern. It needed to match the other changelog entries for consistency.

@jertel jertel merged commit cf1ebb9 into jertel:master Apr 6, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jertel jertel jertel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louzadod @jertel