-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Zabbix alerter #820
Conversation
- add new option zbx_host_from_field for zabbix alerter - update docs for zabbix alerter - add new tests to zabbix_test.py for new zbx_host_from_field option
Add the following verification check settings. zbx_host_from_field: {type: boolean} |
Added |
@nsano-rururu are you ok with the style changes being made with this commit? We usually ask that contributors adopt the existing style already used within the source code, to avoid having a mixture of varying coding styles within the project. If that's not important to you we can accept it as-is. |
If you want to modify existing code, it's best to follow your existing coding style. |
So I need to change the |
That screenshot I pasted was a small example. What we would prefer is to undo all of your formatting changes, and only submit the logic changes required for your PR functionality. |
- zabbix.py - zabbix_test.py
Fixed :) |
Thanks for the contribution! |
Description
Add the ability to specify
zbx_host
from available elasticsearch field.By default, zabbix alerter send "1" to single host with specified
zbx_host
hostname. For a large number of hosts in zabbix, it would be convenient to specifyzbx_host
value from available elasticsearch field.More details - #812
Checklist
make test-docker
with my changes.Questions or Comments