Fix for "Not Working In Windows #588" #629
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix as discussed in #588.
There are still some issues with the tests and coverage running on Windows. These issues are not impairing the functionality of this fix. All tests are green except the after hook described below.
Tests: After hook from https://github.com/jenius/roots/blob/master/test/index.coffee is not working.
Coverage: Istanbul seems to have some issues with the parameters on Windows. I'm not sure how to fix this and currently don't have time to investigate further.