Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to start Flood on a unix socket #679

Closed
1 task done
Scrxtchy opened this issue Oct 19, 2023 · 0 comments · Fixed by #680
Closed
1 task done

Unable to start Flood on a unix socket #679

Scrxtchy opened this issue Oct 19, 2023 · 0 comments · Fixed by #680

Comments

@Scrxtchy
Copy link
Contributor

Type: Bug Report

  • Try to follow the update procedure described in the README and try again before opening this issue.

Your Environment

  • Version used:
  • Environment name and version:
    • Node.js version v20.6.1
    • npm version 9.8.1
  • Operating system and version: Gentoo Base System release 2.14

Summary

Type checking and strict objects forbids my ability to start Flood on a unix socket on existing code

Expected Behavior

I should be able to set the port value to a String to start a listen server on a unix socket by passing a string into a server.listen() param via expressjs

Current Behavior

Flood fails to start, demanding a port to be a number value

Possible Solution

Adjust the config type checking to allow strings in the port value, and the host value to be optional.

Steps to Reproduce

  1. start flood with a path argument into --port

Context

I would like to remove the need to run Flood on a unix domain socket behind an nginx reverse proxy, reducing the overhead that is involved with TCP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant