server: remove port requirement, permit running on paths #680
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unrestricts types when using settings values via CLI, permitting users to use otherwise unused code to run the server while listening to a path.
By setting yarg's type of the floodServerPort to a string, the support is maintained to respect a number value through the NormalisePort function, if the user supplies a number, it is treated as a number despite being of a string type.
I've added a
process.on('exit')
check to the web server, as if you don't properly close the listen server on a socket, the socket is never cleaned up and is regarded still in use on the next startupRelated Issue
closes #679
Screenshots
flood running behind an nginx proxy via
proxy_pass http://unix:/home/scratch/flood/flood.sock;
Types of changes