Run compaction every dbclean interval
#834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Run
nedbcompaction everydbcleaninterval.nedbonly appends a deleted tag for data deletion, so deleting data won't shrink the on-disk datastore size. Compaction rewrites the entire DB into datastore.This was originally intended to fix #399, #645, but that was apparently already fixed in af8de75. However, it's still in theory for other datastores to write too much stuff into datastores (e.g. feed), so compaction after db cleanup should help.
Related Issue
#399, #645.
#399 (comment) also mentioned the transmission log, which doesn't seem to be managed by
nedb. That is out-of-scope of this PR.Types of changes