Handle case when conn.getErrorStream() is null #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcantoine-bibeau
force-pushed
the
fix.error.handling
branch
from
e4b5400 to
c556d07
Compare
|
Have you been able to run at least some of the tests? |
….getResponseMessage()
marcantoine-bibeau
force-pushed
the
fix.error.handling
branch
from
c556d07 to
3806067
Compare
|
Sorry, kinda closed my work session a bit too fast last Friday :( |
|
Yeah. They require a pretty specific Salesforce org setup to pass. I have not developed this library actively in about a decade, so I probably won't get around to doing anything about the tests. |
|
Merged and released as 0.0.46 |
|
Thanks a lot @jesperfj! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle case when conn.getErrorStream() is null by fallbacking on conn.getResponseMessage()