Improve mouse handling in editable views #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to the code in GoToEndOfLine, we need to move left by one character when setting the cursor position to a soft line break, so that we end up at the last whitespace before the line break. This fixes pressing up-arrow or down-arrow at the end of a line when jumping to an auto-wrapped line that is shorter.
The logic didn't take scrolling into account; also, not only do we need to constrain the x position to the line length, but also the y position to the number of lines.
We insert \0 cells at the end of lines, presumably to properly support turning off styles at line ends. When clicking into an editable view after the end of a line, we need to skip past these.
v.SetCursor doesn't do this, we need to call SetCursor2D on the TextArea in addition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewed as part of jesseduffield/lazygit#3836.