Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List panel filtering #392

Merged
merged 39 commits into from
Nov 10, 2022
Merged

List panel filtering #392

merged 39 commits into from
Nov 10, 2022

Conversation

jesseduffield
Copy link
Owner

@jesseduffield jesseduffield commented Oct 23, 2022

This PR adds the ability to filter on side panels by pressing '/' and typing in some text.

There are many other things this PR does that I added in the process:

  • refactoring to DRY up the code by introducing a SideListPanel struct
  • adding deadlock-detecting mutexes when in debug mode
  • fixed a bug in gocui related to horizontal scrolling
  • added gui.Menu function for creating menus (following Lazygit's lead)

One of the purposes of my refactor is to make it easy to add another side panel, as I expect a networks panel will be added soon enough.

@jesseduffield jesseduffield merged commit 04cf343 into master Nov 10, 2022
@jesseduffield jesseduffield deleted the list-panel-filtering branch November 10, 2022 09:18
@jesseduffield
Copy link
Owner Author

I'm gonna test this myself locally for a few days before cutting a release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant