`return-alt1` keybind does not work

[letstakeawalk]

Describe the bug
return-alt1 keybinding config does not work

To Reproduce
configure as below:

# ...
keybinding:
    universal:
        return: 'q'
        return-alt1: '<c-q>'
#...

Expected behavior
Pressing <C-q> should exit input box such as commit prompt but does nothing.

Screenshots
If applicable, add screenshots to help explain your problem.

Version info:
Run lazygit --version and paste the result here
commit=16802a048e0425182f08cf0e9a2bc31480e9a55d, build date=2023-02-01T11:02:43Z, build source=binaryRelease, version=0.37.0, os=darwin, arch=arm64, git version=2.39.1
lazygit installed via homebrew
Run git --version and paste the result here
git version 2.39.1

Additional context
I assume this PR introduced the return-alt1 config. The author used similar keybindings but the other way around. Setting return: '<c-q>' and return-alt1: 'q' does work as intended, but my config does not work

Note: please try updating to the latest version or manually building the latest master to see if the issue still occurs.

[mark2185]

Could you try building master and see if it still happens?

It should have been fixed by #2435.

[iovis]

I'm guessing this feature got removed in v0.38? I like using q as return, but for dismissing the commit prompt if I wanted to cancel it I needed to press <esc>.

Is there any workaround available?

[mark2185]

I'm guessing this feature got removed in v0.38?

Correct.

I like using q as return, but for dismissing the commit prompt if I wanted to cancel it I needed to press <esc>.

Is there any workaround available?

I think you should now be able to use return on all the windows/panes, except the commit prompt and such since that has to pass through q as an input to the prompt, otherwise you wouldn't be able to type q.

[iovis]

I think you should now be able to use return on all the windows/panes, except the commit prompt and such since that has to pass through q as an input to the prompt, otherwise you wouldn't be able to type q.

Hahaha, yeah, that's why the return-alt1 was useful for my use case (I realized that I cancel a lot more than I thought to double check what I'm committing haha). Thank you for clarifying!

[stefanhaller]

Yeah, not being able to see the diff while you are typing the commit message is a pretty big problem. Not sure what a good solution to that could be.

Personally I work around it by setting the git config commit.verbose to true, and then using C instead of c most of the time. That way I can at least see the diff right there in the editor, and as an added bonus I can auto-complete identifiers that occur in the diff, which is often helpful.

[iovis]

Personally I work around it by setting the git config commit.verbose to true, and then using C instead of c most of the time. That way I can at least see the diff right there in the editor, and as an added bonus I can auto-complete identifiers that occur in the diff, which is often helpful.

Yeah, I use C most of the time too (although I didn't know about commit.verbose, I should probably enable that), but sometimes I feel like it's going to be a simple commit message and then I end up wanting the context or something like that and get myself in a bind for not being able to cancel haha.

Maybe I should just rebind C to c, I think the config you mentioned is likely enough and I have an easier way to cancel from my editor anyway. Thanks for the idea!