Yank mapping (y) in Patch Options is executing the option that is currently highlighted

[sungkang]

Describe the bug
When pressing the y keymap within the Patch Options, the copy to clipboard is not executed.
When navigating down to the option and pressing enter works fine.
If you press y on any currently highlighted option, it will execute that action instead of the copy to clipboard action.

To Reproduce
Steps to reproduce the behavior:

1. Navigate to the "Commits - Reflog" view panel.
2. Press enter to view the selected item's files.
3. Press a to add all the files of the commit to a custom patch.
4. Press ctrl-p to open the Patch Options modal.
5. Press y to copy patch to clipboard.

Expected behavior
I expect the "copy patch to clipboard" option to be called, but the first option it defaults to "reset patch" is called instead.

Screenshots
If applicable, add screenshots to help explain your problem.

Version info:
commit=, build date=, build source=homebrew, version=0.37.0, os=darwin, arch=arm64, git version=2.39.2
git version 2.39.2

Additional context
Add any other context about the problem here.

Note: please try updating to the latest version or manually building the latest master to see if the issue still occurs.

[mark2185]

Reproducible, thanks for reporting!

[jesseduffield]

I can't recall where we landed on this y/n discussion. I'm still in favour of depending only on enter and escape for confirming/cancelling

[mark2185]

I don't think we landed anywhere.

I may have been against it in the past, but I'm up for it now. Who needs more than one way to confirm or discard something?

[jesseduffield]

That's what I'm thinking. The more keybindings we have available for things the better

[stefanhaller]

For the record, I agree. I didn't even know that you can use y to confirm arbitrary prompts.

[mark2185]

Solved by #2495 .