-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: support filtering #1993
WIP: support filtering #1993
Conversation
@jesseduffield I'd love to see this feature land! Especially for filtering branches. This filtering functionality would be great (since it's lazier than having to nail exact searches with See #2057 for some discussion about use cases (it mentions also supporting fuzzy search results, but even just filtering lists by exact search strings would be a lovely first step). Either way -- thanks so much for |
I'm closing this PR cos it's drifted quite a bit from the master branch, and I've learnt a better way of doing filtering from adding the feature to lazydocker. I WILL get back to this! |
We already support searching in views, however this PR introduces a different kind of searching. In list views we want to actually filter down the items of the list based on what matches your search string. On the other hand, for the main view, we still want to show the original contents without filtering anything down, but we want to highlight the matches.
Open questions:
TODO: