Skip to content

Add alternative Confirm and Return hotkeys for confirmation windows #2768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vlad-psh wants to merge 1 commit into
base: master
Choose a base branch
from
+12 −0
Open

Add alternative Confirm and Return hotkeys for confirmation windows #2768

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/Config.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,8 @@ keybinding:
goInto: '<enter>'
openRecentRepos: '<c-r>'
confirm: '<enter>'
# confirm-prompt: 'y' # confirm prompt messages (alternative to the 'confirm')
# cancel-prompt: 'n' # close/abort prompt messages (alternative to the 'return')
remove: 'd'
new: 'n'
edit: 'e'
Expand Down
2 changes: 2 additions & 0 deletions pkg/config/user_config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,8 @@ type KeybindingUniversalConfig struct {
GoInto string `yaml:"goInto"`
Confirm string `yaml:"confirm"`
ConfirmInEditor string `yaml:"confirmInEditor"`
ConfirmPrompt string `yaml:"confirm-prompt"`
CancelPrompt string `yaml:"cancel-prompt"`
Remove string `yaml:"remove"`
New string `yaml:"new"`
Edit string `yaml:"edit"`
Expand Down
8 changes: 8 additions & 0 deletions pkg/gui/controllers/confirmation_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,14 @@ func (self *ConfirmationController) GetKeybindings(opts types.KeybindingsOpts) [
Description: self.c.Tr.CloseCancel,
Display: true,
},
{
Key: opts.GetKey(opts.Config.Universal.ConfirmPrompt),
Handler: func() error { return self.context().State.OnConfirm() },
},
{
Key: opts.GetKey(opts.Config.Universal.CancelPrompt),
Handler: func() error { return self.context().State.OnClose() },
},
{
Key: opts.GetKey(opts.Config.Universal.TogglePanel),
Handler: func() error {
Expand Down