Copy branch url to clipboard

[skolj]

• PR Description
  This change allows copying branch URL to clipboard in the branches view. The existing copy X items are moved to a Copy to Clipboard menu with the following copy options:

• Branch name
• Branch URL (key: u)
• Pull request URL (key: p)

Fixes #1959

• Please check if the PR fulfills these requirements

• Cheatsheets are up-to-date (run go generate ./...)
• Code has been formatted (see here)
• Tests have been added/updated (see here for the integration test guide)
• Text is internationalised (see here)
• Docs (specifically docs/Config.md) have been updated if necessary
• You've read through your own file changes for silly mistakes etc

[mark2185]

Looks good!

Have just one suggestion :)

[mark2185]

Just thinking out loud: I'm okay with having two of the attributes with the same text, but if it happens for a third time maybe it's best to make them all the same attribute.

[skolj]

I think I'll just create a generic Copy to Clipboard attribute since the copy menu would have the same label everywhere.

[skolj]

looks like there's already a CopyToClipboard attribute.

[mark2185]

Looks good to me!

[mark2185]

I take it these are correct because I've only checked for github.

[skolj]

I couldn't verify the branch URL for bitbucket server. The others should be correct.

[karimkhaleel]

Getting some weird behaviors when in a repo with multiple remotes. But I think it's not due to the changes in this PR, but rather with the way getHostingServiceMgr is implemented.

Copy branch url seems to only use the base url of the upstream named origin. This results in a 404 if the upstream named origin does not have a branch with that name.

Maybe we can find a way to pass in the name of the upstream of the branch we want to get the url / open a pull request for? We can always default to origin.

Especially since this is already what we are doing in CheckRemoteBranchExists.

[skolj]

Valid point @karimkhaleel. I'm not sure how we'd deal with upstreams (for from and to branches) when creating pull requests given that lazygit has a pull request options menu where the target branch can be selected. The branch URL part is clear to me.

[karimkhaleel]

I'm not sure how we'd deal with upstreams (for from and to branches) when creating pull requests given that lazygit has a pull request options menu where the target branch can be selected.

Maybe we just leave the to branch as default, like the first option in the View pull request options... menu? This is already what the lowercase o keybind does in the branches menu anyway.

[jesseduffield]

Maybe we just leave the to branch as default, like the first option in the View pull request options... menu? This is already what the lowercase o keybind does in the branches menu anyway.

I agree