Add support for Unspecified Author Colors #3496
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Adds the support for the user to control the colors lazygit picks from when generating colors for unspecified authors
Notes
There were some questions that came up w.r.t. how this plays with the wildcard
authorColors
syntax. Notably, how to handle the case when both are present. In this iteration of the pr I've just removed support for that syntax. I'm open to suggestions of a more elegant solution.Additionally, It was difficult to write robust tests for these changes. Tests I couldn't find a way to implement include:
This is because of the lack of existing comparison functionality for
TextStyle
s. Implementing that seemed out of scope for this change. I would love input on how to either refactor this feature to make it more easily testable without having to introduce those changes.go generate ./...
)docs/Config.md
) have been updated if necessary