Skip to content

Conversation

@gmlexx
Copy link
Contributor

@gmlexx gmlexx commented Jul 6, 2024

  • PR Description

Git output might contain a useful http links call for actions, for example:

remote:
remote: To create a merge request for <branch>, visit:
remote:   https://gitlab.<company>.com/<project>/-/merge_requests/new?merge_request%5Bsource_branch%5D=<branch>
remote:
  • Please check if the PR fulfills these requirements
  • Cheatsheets are up-to-date (run go generate ./...)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • Docs have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

@gmlexx
Copy link
Contributor Author

gmlexx commented Sep 2, 2024

Hey @jesseduffield, could you have a look, please?

@stefanhaller
Copy link
Collaborator

@gmlexx Ah sorry, I broke this with recent changes. If you rebase on master, you'll find that this no longer compiles, as the HandleGenericClick function was removed meanwhile.

One way to fix this is to reintroduce the function, of course, but I'm not sure that's the best one. Now that we support proper hyperlinks, I have the feeling we should do something similar to what we do for confirmation popups in CreatePopupPanel, see the underlineLinks function (which is a bit badly named now, because it not only underlines the links, but actually turns them into real links). I suppose we would do that in prefixWriter.Write in extras_panel.go.

For now this is just a feeling, I didn't verify that it will work when we do it this way. I'm a bit out of energy today, but I could have a closer look one of the next days. Feel free to experiment with this meanwhile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants